fix(gobd_company): replace literal newline in string with \n escape#429
Merged
Conversation
…CodeRabbit P1) PR #426's `body_source = "<literal newline>".join(body_lines)` was a SyntaxError that escaped the smoke test because the smoke test only exercises uom (the ORM-only path), not l10n_de's data extractor. CodeRabbit flagged this in the final review at `b3fc9c79` as a "duplicate" comment carried forward; it remained unresolved through merge. Fix: `"\n".join(body_lines)` — the intended one-char escape. Now `python -m ast` parses gobd_company.py cleanly. Smoke test still passes (no regression). https://claude.ai/code/session_017gZ6sPRXYPj5n7uJ7NBtRv
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR fixes string concatenation in the GOBD company data extractor. The ChangesMethod Body Inspection String Join Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
AdaWorldAPI
added a commit
that referenced
this pull request
May 28, 2026
…gliteral fix(gobd_company): replace literal newline in string with \n escape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny fix for a SyntaxError CodeRabbit flagged as a "duplicate" thread in its final PR #426 review at
b3fc9c79— the thread remained unresolved through merge.gobd_company.py:51had a literal newline embedded inside a string literal:This is invalid Python —
ast.parse(...)raisesSyntaxError. The smoke test onuomdidn't catch it because the smoke test exercises only the ORM (ast) extraction path;gobd_company.pyis only imported by thedataCLI subcommand onl10n_de.Fix:
The intended single-char newline escape.
Verification
Test plan
python -m astparses the filetests/test_smoke_uom.pyPASS (no regression)python -m odoo_blueprint_extractor data --addon l10n_de --out -end-to-end (the path that was broken)https://claude.ai/code/session_017gZ6sPRXYPj5n7uJ7NBtRv
Generated by Claude Code
Summary by CodeRabbit